Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallel instance creation opt-in option #20

Merged
merged 18 commits into from
Feb 3, 2024

Conversation

canihavethisone
Copy link
Contributor

@canihavethisone canihavethisone commented Jan 8, 2024

This adds an option to create instances in parallel, particularly useful when launching larger images or Windows, for example.

Note that I have not expanded tests - open to suggestions/assistance to do this please.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels beyond my knowledge of beaker/openstack but I think there is some Ruby thread dragons hiding in this change. Can you please double-check if the points where I added in-line comments are as expected?

lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
@bastelfreak
Copy link
Member

@canihavethisone with which beaker version are you testing this? beaker 5 by any chance? Do you require Ruby < 2.7 support?

@canihavethisone
Copy link
Contributor Author

canihavethisone commented Jan 8, 2024

@canihavethisone with which beaker version are you testing this? beaker 5 by any chance? Do you require Ruby < 2.7 support?

I'm using beaker 5.5.0 and ruby 3.1.0 gems. Open to opinion, but I think pushing to v3 is ok?

@bastelfreak
Copy link
Member

I'm using beaker 5.5.0 and ruby 3.1.0 gems
I just wanted to know if the openstack plugin is compatible with beaker 5 where we introduced a lot of changes. Good to know that works.

@canihavethisone
Copy link
Contributor Author

canihavethisone commented Jan 24, 2024

@bastelfreak Can this be merged and release yet please?

lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
lib/beaker/hypervisor/openstack.rb Outdated Show resolved Hide resolved
@canihavethisone
Copy link
Contributor Author

canihavethisone commented Jan 30, 2024

this is the initial provisioning display now:

Hypervisor for win10-agent is openstack
Hypervisor for win11-agent is openstack
Hypervisor for rocky-9-stream-master is openstack
Beaker::Hypervisor, found some openstack boxes to create
Provisioning OpenStack in parallel
Provisioning OpenStack
Adding optional key_name beaker to win10-agent (vfkpgatedu)
Provisioning win10-agent (vfkpgatedu)
OpenStack: Looking up flavor 'windows'
Provisioning OpenStack
Adding optional key_name beaker to win11-agent (iofnzvujmg)
Provisioning win11-agent (iofnzvujmg)
OpenStack: Looking up flavor 'windows'
Provisioning OpenStack
Adding optional key_name beaker to rocky-9-stream-master (opkghcdvxt)
Provisioning rocky-9-stream-master (opkghcdvxt)
OpenStack: Looking up flavor 'linux.server'

Fixed `hack_etc_hosts` location and functionality
@bastelfreak bastelfreak changed the title Added parallel instance creation opt-in option Add parallel instance creation opt-in option Feb 3, 2024
@bastelfreak bastelfreak merged commit 3ea64fd into voxpupuli:master Feb 3, 2024
2 checks passed
@canihavethisone canihavethisone deleted the add-parallel-creation branch February 4, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants