Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gui): invalid chunk/pad range, fix slider minimum #616

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brandostrong
Copy link
Contributor

librosa.util.exceptions.ParameterError: Invalid hop_length: 0 on 0 chunk seconds
Calculated padded input size per channel: (1). Kernel size: (2). Kernel size can't be greater than actual input size on 0 pad seconds

librosa.util.exceptions.ParameterError: Invalid hop_length: 0 on 0 chunk seconds
Calculated padded input size per channel: (1). Kernel size: (2). Kernel size can't be greater than actual input size on 0 pad seconds
@34j
Copy link
Collaborator

34j commented May 12, 2023

I would appreciate it if you could fix other sliders as well

@brandostrong
Copy link
Contributor Author

Hi, can you clarify?

@34j
Copy link
Collaborator

34j commented May 13, 2023

It would be nice if the slider for the maximum chunk seconds and the four sliders for "Realtime" also had a proper minimum value.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (b116a05) 19.55% compared to head (774b0f6) 19.56%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #616      +/-   ##
==========================================
+ Coverage   19.55%   19.56%   +0.01%     
==========================================
  Files          39       39              
  Lines        3427     3424       -3     
  Branches      477      476       -1     
==========================================
  Hits          670      670              
+ Misses       2740     2737       -3     
  Partials       17       17              
Impacted Files Coverage Δ
src/so_vits_svc_fork/gui.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

@brandostrong brandostrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix #649 and fix #616

@34j
Copy link
Collaborator

34j commented May 18, 2023

@brandostrong #649 is not a bug. (#95) If you think it is really unfriendly, please create the feature to make the default at startup the same as the last time, or show additional prompts, etc. please create a separate PR for that. Also, I personally think a lower limit of 0.01 seconds for each slider would be preferable.

@brandostrong
Copy link
Contributor Author

hi, I now see why it is like this. It makes sense for the presets to change back to "default file" instead of any other preset, but should it update the selections with the default? Would a good comprimise be removing apply_preset("Default File") and keeping window["presets"].update(set_to_index=list(load_presets().keys()).index("Default File")) ?

Otherwise, I can look at adding a toggle to "remember" settings.

@34j
Copy link
Collaborator

34j commented May 20, 2023

I don't even know what is the best solution, though I'd rather have a preset made than click on a toggle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants