Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the context choosing error after migration case. #8293

Merged

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Oct 14, 2024

Try to use the normal import way in ginkgo tests.
Change the FAIL_FAST default value to false.

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@blackpiglet blackpiglet self-assigned this Oct 14, 2024
@blackpiglet blackpiglet added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.19%. Comparing base (ba0dbb9) to head (6a1d8df).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8293      +/-   ##
==========================================
- Coverage   59.20%   59.19%   -0.02%     
==========================================
  Files         367      367              
  Lines       30838    30840       +2     
==========================================
- Hits        18259    18255       -4     
- Misses      11119    11124       +5     
- Partials     1460     1461       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ywk253100
ywk253100 previously approved these changes Oct 15, 2024
@@ -53,7 +53,7 @@ GINKGO_LABELS ?=
# When --fail-fast is set, the entire suite will stop when the first failure occurs.
# Enable --fail-fast by default.
# https://onsi.github.io/ginkgo/#mental-model-how-ginkgo-handles-failure
FAIL_FAST ?= true
FAIL_FAST ?= false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the impact for this change? will it take more time for testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FAIL_FAST flag determines how to handle errors met during the test suite running.
If FAIL_FAST is set to true, the test suite stops running immediately.
If FAIL_FAST is set to false, the test suite continues running on meeting test error.

The FAIL_FAST flag is introduced to help debug the test error, so set the default value to false, and let the Jenkins pipeline can pass the value to determine whether the flag should be turned on.

Change the FAIL_FAST default value to false.

Signed-off-by: Xun Jiang <xun.jiang@broadcom.com>
@blackpiglet blackpiglet force-pushed the fix_e2e_namespace_missing_issue branch from d644116 to 6a1d8df Compare October 15, 2024 05:49
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ywk253100 ywk253100 merged commit 2b3a0b4 into vmware-tanzu:main Oct 16, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants