feat(json)!: add json.stringify: 'auto' and make that the default
#18303
+194
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
p2-nice-to-have
|
|
sapphi-red
commented
Oct 8, 2024
Comment on lines
53
to
55
| // use 10kB as a threshold | ||
| // https://v8.dev/blog/cost-of-javascript-2019#:~:text=A%20good%20rule%20of%20thumb%20is%20to%20apply%20this%20technique%20for%20objects%20of%2010%20kB%20or%20larger | ||
| (options.stringify === 'auto' && json.length >= 10 * 1000) |
There was a problem hiding this comment.
Maybe we should benchmark this to find out whether the threshold has changed over the last five years.
There was a problem hiding this comment.
I ran the benchmark: https://github.com/sapphi-red/json-parse-benchmark
It's difficult to measure where the threshold is due to the overhead of starting the JS engines. But the perf benefit still exists. Probably fine to go with 10kB for now.
bluwy
reviewed
Oct 16, 2024
bluwy
approved these changes
Oct 16, 2024
patak-dev
approved these changes
Oct 16, 2024
ArnaudBarre
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
namedExportswithstringify: truestringify: 'auto'stringifyto'auto'fromfalse.
It is known that embedding an JSON serializable object as a string reduces the parse cost than embedding the object directly for large objects. This was possible by setting
stringify: true, but that made all JSON imports into serialized format. Alsostringify: truedid not supportnamedExports, so it was not possible to enable it by default.