Use pion/webrtc/v4

[edaniels]

I'd suggest moving to v4 since v3 is no longer supported.

[edaniels]

Test failure unrelated

[dgottlieb]

All of the changes you made in the v3 branch for us are in the v4 branch? Particularly the ones that weren't included in the old v3 branch because they were deemed backwards breaking?

I think the main one being the rtp passthrough related change where OnTrackReceived will be called once the SDP is renegotiated (as opposed to also requiring the first packet to be sent).

[edaniels]

All of the changes you made in the v3 branch for us are in the v4 branch? Particularly the ones that weren't included in the old v3 branch because they were deemed backwards breaking?

I think the main one being the rtp passthrough related change where OnTrackReceived will be called once the SDP is renegotiated (as opposed to also requiring the first packet to be sent).

Yeah that RTP one would still need to be addressed here. Everything else in the fork is present in v4.

[edaniels]

All of the changes you made in the v3 branch for us are in the v4 branch? Particularly the ones that weren't included in the old v3 branch because they were deemed backwards breaking?
I think the main one being the rtp passthrough related change where OnTrackReceived will be called once the SDP is renegotiated (as opposed to also requiring the first packet to be sent).

Yeah that RTP one would still need to be addressed here. Everything else in the fork is present in v4.

I'm offering up pion/webrtc#2933 to see if we can get it in without simulcast changes (that viam doesn't use).

[edaniels]

@dgottlieb I got the OnTrack bit in as a setting

[edaniels]

@dgottlieb this plus a few lines above ends up fixing a case where some tests don't see the channel close with an error "in time"