Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#145 #146

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

#145 #146

wants to merge 2 commits into from

Conversation

Yaytay
Copy link
Contributor

@Yaytay Yaytay commented Mar 18, 2022

Motivation:

Remove @GenIgnore from addConnectionEstablishedCallback

@Yaytay Yaytay requested a review from vietj March 18, 2022 07:17
@Yaytay
Copy link
Contributor Author

Yaytay commented Mar 18, 2022

Hi @vietj,

Please can you take a look at this, is it OK to remove the @GenIgnore from addConnectionEstablishedCallback?
The aim is to make it available to the Rx users.
I'm not getting any errors, but I'm not sure that's a good indication in this case :)

If this isn't OK, is there a way to provide a Rx-compatible method that lets the caller register a method that completes asynchronously?
Either returning a Future or taking in a Handler would be fine.

Note that the connectionEstablishCallback is called multiple times independently, which prevents some options.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vietj vietj Awaiting requested review from vietj

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Yaytay