Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Catch2 to version 3.4.0 #1287

Merged
merged 3 commits into from
Jan 1, 2024
Merged

Update Catch2 to version 3.4.0 #1287

merged 3 commits into from
Jan 1, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Jan 1, 2024

Fixes #987

Details

Fixes #987

### Details

- We no longer use the old Catch2 single-header distribution model but the new more standard library distribution model, which comes with much better compile-time performance. Details in https://github.com/catchorg/Catch2/blob/devel/docs/migrate-v2-to-v3.md.
@ibc ibc requested review from jmillan and nazar-pc January 1, 2024 12:53
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but I don't think refactoring made things better

worker/tasks.py Show resolved Hide resolved
@ibc ibc merged commit 28ff4a7 into v3 Jan 1, 2024
20 checks passed
@ibc ibc deleted the update-catch2-to-3.4.0 branch January 1, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Catch2 to version 3
2 participants