fix pip usage

versatica · Aug 9, 2024 · 8ab79df · 8ab79df
1 parent 600ff04
commit 8ab79df
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/.github/workflows/mediasoup-worker-fuzzer.yaml b/.github/workflows/mediasoup-worker-fuzzer.yaml
@@ -16,6 +16,7 @@ jobs:
           - os: ubuntu-24.04
             cc: clang
             cxx: clang++
+            pip-break-system-packages: true
         build-type:
           - Release
           - Debug
@@ -34,12 +35,12 @@ jobs:
         uses: actions/checkout@v4
 
       # We need to install pip invoke manually.
-      - if: runner.os != 'macOS'
+      - if: ${{ !matrix.build.pip-break-system-packages }}
         name: pip3 install invoke
         run: pip3 install invoke
 
-      # In macOS we need to specify this option.
-      - if: runner.os == 'macOS'
+      # In modern OSs we need to run pip with this option.
+      - if: ${{ matrix.build.pip-break-system-packages }}
         name: pip3 install --break-system-packages invoke
         run: pip3 install --break-system-packages invoke
 

diff --git a/.github/workflows/mediasoup-worker-prebuild.yaml b/.github/workflows/mediasoup-worker-prebuild.yaml
@@ -19,6 +19,8 @@ jobs:
             cc: gcc
             cxx: g++
           # Worker prebuild for Linux with kernel version 6 Ubuntu (22.04).
+          # Let's not use Ubutu 24.04 to avoid same potential problem as described
+          # above.
           - os: ubuntu-22.04
             cc: gcc
             cxx: g++

diff --git a/.github/workflows/mediasoup-worker.yaml b/.github/workflows/mediasoup-worker.yaml
@@ -34,15 +34,19 @@ jobs:
           - os: ubuntu-24.04
             cc: gcc
             cxx: g++
+            pip-break-system-packages: true
           - os: ubuntu-24.04
             cc: clang
             cxx: clang++
+            pip-break-system-packages: true
           - os: macos-12
             cc: gcc
             cxx: g++
+            pip-break-system-packages: true
           - os: macos-14
             cc: clang
             cxx: clang++
+            pip-break-system-packages: true
           - os: windows-2022
             cc: cl
             cxx: cl
@@ -81,12 +85,12 @@ jobs:
             ${{ matrix.build.os }}-node-${{matrix.build.cc}}-
 
       # We need to install pip invoke manually.
-      - if: runner.os != 'macOS'
+      - if: ${{ !matrix.build.pip-break-system-packages }}
         name: pip3 install invoke
         run: pip3 install invoke
 
-      # In macOS we need to specify this option.
-      - if: runner.os == 'macOS'
+      # In modern OSs we need to run pip with this option.
+      - if: ${{ matrix.build.pip-break-system-packages }}
         name: pip3 install --break-system-packages invoke
         run: pip3 install --break-system-packages invoke