Updates tests due to unflagged sync stack traces

vercel · Oct 16, 2024 · 25afc7a · 25afc7a
1 parent 929b6d8
commit 25afc7a
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 12 deletions.
diff --git a/test/development/acceptance-app/ReactRefreshLogBox.test.ts b/test/development/acceptance-app/ReactRefreshLogBox.test.ts
@@ -852,7 +852,17 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
  const stackFrames = await Promise.all(
  stackFrameElements.map((f) => f.innerText())
  )
- expect(stackFrames).toEqual([])
+ expect(stackFrames).toEqual(
+ // TODO: Show useful stack
+ [
+ // Internal frames of React.
+ // Feel free to adjust until we show useful stacks.
+ '',
+ '',
+ '',
+ '',
+ ]
+ )
  } finally {
  await cleanup()
  }
@@ -909,6 +919,13 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
  Page
  app/page.js (5:6)
  `,
+ // TODO: Show useful stack
+ // Internal frames of React.
+ // Feel free to adjust until we show useful stacks.
+ '',
+ '',
+ '',
+ '',
  ]
  : [
  outdent`
@@ -957,7 +974,17 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox app %s', () => {
  const stackFrames = await Promise.all(
  stackFrameElements.map((f) => f.innerText())
  )
- expect(stackFrames).toEqual([])
+ expect(stackFrames).toEqual(
+ // TODO: Show useful stack
+ [
+ // Internal frames of React.
+ // Feel free to adjust until we show useful stacks.
+ '',
+ '',
+ '',
+ '',
+ ]
+ )
  } finally {
  await cleanup()
  }

diff --git a/test/development/app-dir/dynamic-error-trace/index.test.ts b/test/development/app-dir/dynamic-error-trace/index.test.ts
@@ -48,16 +48,14 @@ describe('app dir - dynamic error trace', () => {
  )
  expect(stackFrames).toEqual(
  // TODO: Show useful stack
- isReactExperimental
- ? [
- // Internal frames of React.
- // Feel free to adjust until we show useful stacks.
- '',
- '',
- '',
- '',
- ]
- : []
+ [
+ // Internal frames of React.
+ // Feel free to adjust until we show useful stacks.
+ '',
+ '',
+ '',
+ '',
+ ]
  )
 
  const codeframe = await getRedboxSource(browser)