Skip to content

Commit

Permalink
make VerifyDigest param types explicit
Browse files Browse the repository at this point in the history
Signed-off-by: qmuntal <qmuntaldiaz@microsoft.com>
  • Loading branch information
qmuntal committed Jul 18, 2023
1 parent d314e95 commit 2893601
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ecdsa.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func (ev *ecdsaVerifier) Verify(content []byte, signature []byte) error {
// Otherwise, it returns ErrVerification.
//
// Reference: https://datatracker.ietf.org/doc/html/rfc8152#section-8.1
func (ev *ecdsaVerifier) VerifyDigest(digest, signature []byte) error {
func (ev *ecdsaVerifier) VerifyDigest(digest []byte, signature []byte) error {
// verify signature
r, s, err := decodeECDSASignature(ev.key.Curve, signature)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion rsa.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func (rv *rsaVerifier) Verify(content []byte, signature []byte) error {
// Otherwise, it returns ErrVerification.
//
// Reference: https://datatracker.ietf.org/doc/html/rfc8152#section-8.1
func (rv *rsaVerifier) VerifyDigest(digest, signature []byte) error {
func (rv *rsaVerifier) VerifyDigest(digest []byte, signature []byte) error {
if err := rsa.VerifyPSS(rv.key, rv.alg.hashFunc(), digest, signature, &rsa.PSSOptions{
SaltLength: rsa.PSSSaltLengthEqualsHash, // defined in RFC 8230 sec 2
}); err != nil {
Expand Down

0 comments on commit 2893601

Please sign in to comment.