Modernize the active_support requires
#837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burgestrand
force-pushed
the
kbs/modernize-active_support-require
branch
2 times, most recently
from
ddc4550
to
d232396
Compare
Burgestrand
force-pushed
the
kbs/code-janitoring
branch
2 times, most recently
from
ba324e4
to
e296e83
Compare
Burgestrand
force-pushed
the
kbs/modernize-active_support-require
branch
from
d232396
to
c00d2e7
Compare
> In order to have the smallest default footprint possible, Active Support loads the minimum dependencies by default. It is broken in small pieces so that only the desired extensions can be loaded. https://guides.rubyonrails.org/active_support_core_extensions.html#stand-alone-active-support This was changed in Rails 3, released 2010-08-29. - We're not using anything from `core_ext/module/introspection` - We're not using blank or present from `core_ext/object/blank` - We're not using `autoload`
Burgestrand
force-pushed
the
kbs/modernize-active_support-require
branch
from
c00d2e7
to
56e73a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were kind of doing it wrong, and it worked in tests by accident because we required railties and actionpack.
To do
PS: Thank you for contributing to Pundit ❤️