Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.2 fix #2503

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Rc 1.2 fix #2503

merged 1 commit into from
Oct 26, 2024

Conversation

avifenesh
Copy link
Collaborator

@avifenesh avifenesh commented Oct 22, 2024

This pull request includes multiple changes to the GitHub Actions workflows and configuration files to improve compatibility, update dependencies, and streamline processes. The most important changes include fixing the alpine version used to fix node release.
Other noticeable changes include Node.js and Python versions, adjustments to the build matrix, and various workflow improvements.

Workflow Improvements:

  • Updated Node.js version to the latest in multiple workflows (.github/workflows/node.yml, .github/workflows/npm-cd.yml, .github/workflows/ort.yml) [1] [2] [3].
  • Changed conditions and improved logic for setting up Node.js in the npm continuous deployment workflow (.github/workflows/npm-cd.yml) [1] [2].

Dependency Updates:

  • Updated Python version to 3.12 and removed older versions from the PyPI continuous deployment workflow (.github/workflows/pypi-cd.yml).
  • Updated @types/jest dependency in node/package.json.

Build Matrix Adjustments:

  • Reformatted the PACKAGE_MANAGERS and RUNNER fields for better readability in the build matrix (.github/json_matrices/build-matrix.json) [1] [2].

Miscellaneous Changes:

  • Added additional files to the files array in node/package.json for better package management.
  • Improved the repository reset process in the setup-musl-on-linux action (.github/workflows/setup-musl-on-linux/action.yml).

Issue link

This Pull Request is linked to issue 2502

Checklist

Before submitting the PR make sure the following are checked:

  • [v] This Pull Request is related to one issue.
  • [v] Commit message has a detailed description of what changed and why.
  • [v] Tests are added or updated.
  • [v] CHANGELOG.md and documentation files are updated.
  • [v] Destination branch is correct - main or release
  • [v] Commits will be squashed upon merging.

@avifenesh avifenesh self-assigned this Oct 22, 2024
@avifenesh avifenesh requested a review from a team as a code owner October 22, 2024 21:31
@avifenesh avifenesh changed the base branch from main to release-1.2 October 22, 2024 21:32
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add these changes into #2500?

@avifenesh
Copy link
Collaborator Author

Do you want to add these changes into #2500?

When it will be working ill cherry-pick

@Yury-Fridlyand Yury-Fridlyand added node CI CI/CD related labels Oct 22, 2024
…anagement and consistency and fixing alpine release

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
@avifenesh avifenesh merged commit 190939d into release-1.2 Oct 26, 2024
62 checks passed
@avifenesh avifenesh deleted the rc-1.2-fix branch October 26, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI/CD related node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants