Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust - code cleanup, part 1 #2478

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

avifenesh
Copy link
Collaborator

This pull request includes various changes across multiple files to improve code readability, update configurations, and remove deprecated methods.

Configuration Updates:

Dependency and Feature Formatting:

Code Refactoring:

Documentation and Testing:

Additional Changes:

Please make sure you are aware of our contributing guidelines available
here

Issue link

This Pull Request is linked to issue: [#2450 ]

Checklist

Before submitting the PR make sure the following are checked:

  • [v ] This Pull Request is related to one issue.
  • [ v] Commit message has a detailed description of what changed and why.
  • [v ] Tests are added or updated.
  • [v ] CHANGELOG.md and documentation files are updated.
  • [v ] Destination branch is correct - main or release
  • [ v] Commits will be squashed upon merging.

@avifenesh avifenesh added docs Documentation dependency Dependency management 1_2_candidate labels Oct 19, 2024
@avifenesh avifenesh added this to the 1.2 milestone Oct 19, 2024
@avifenesh avifenesh self-assigned this Oct 19, 2024
@avifenesh avifenesh requested a review from a team as a code owner October 19, 2024 11:22
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, this file should not be kept in the respository

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, but for old reasons it's on the part and I don't want to break any one work by completely remove it.
The specific line here is needed for analyzer to understand how to read complicated monorepo, and many had tackle the issue, so we added a shared solution.

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the PR and add changelog

git submodule update --init --recursive
```
3. Install all node dependencies:
2. Install all node dependencies:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this for all clients please

@avifenesh
Copy link
Collaborator Author

Please rename the PR and add changelog

What do you mean by rename pr?

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Oct 21, 2024

What do you mean by rename pr?

Well, I guess "Rust - code cleanup, part 1" is better

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

Not sure, need to confirm with @ikolomi. CI changes have no effect for user too, but we list them there.

@avifenesh
Copy link
Collaborator Author

What do you mean by rename pr?

Well, I guess "Rust - code cleanup, part 1" is better

I think change log are for what relevant in release, no? Its not including changes that has no connection to users

Not sure, need to confirm with @ikolomi. CI changes have no effect for user too, but we list them there.

Yes my question is on CI as well, are we want to include it in release note? Im not sure its relevant
I'll check

@avifenesh avifenesh changed the title Rust/cleaning1 Rust - code cleanup, part 1 Oct 21, 2024
@avifenesh avifenesh merged commit 695697a into valkey-io:release-1.2 Oct 21, 2024
20 checks passed
@avifenesh avifenesh deleted the Rust/Cleaning1 branch October 21, 2024 21:46
BoazBD pushed a commit to BoazBD/valkey-glide that referenced this pull request Oct 22, 2024
Some cleaning for unnecessary code to set the floor for next PR

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
Some cleaning for unnecessary code to set the floor for next PR

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
Some cleaning for unnecessary code to set the floor for next PR

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
cyip10 pushed a commit that referenced this pull request Oct 23, 2024
Some cleaning for unnecessary code to set the floor for next PR

Signed-off-by: avifenesh <aviarchi1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1_2_candidate dependency Dependency management docs Documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants