Make redis-rs part of this repo #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
- Separate the "test" target from the "lint" - Added new "help" target for listing all possible targets Signed-off-by: Eran Ifrah <eifrah@amazon.com>
Signed-off-by: Eran Ifrah <eifrah@amazon.com>
avifenesh
reviewed
Oct 15, 2024
avifenesh
approved these changes
Oct 15, 2024
Muhammad-awawdi-amazon
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Make redis-rs part of this repo * Improved PYTHON DEVELOPERS.md file * Added Makefile for unified build method for all the languages
Muhammad-awawdi-amazon
pushed a commit
to Muhammad-awawdi-amazon/valkey-glide
that referenced
this pull request
Oct 15, 2024
* Make redis-rs part of this repo * Improved PYTHON DEVELOPERS.md file * Added Makefile for unified build method for all the languages Signed-off-by: Muhammad Awawdi <Mawawdi@amazon.com>
| PY_PATH=$(shell find python/.env -name "site-packages"|xargs readlink -f) | ||
| PY_GLIDE_PATH=$(shell pwd)/python/python/ | ||
|
|
||
| all: java java-test python python-test node node-test go go-test python-lint java-lint |
There was a problem hiding this comment.
node-lint go-lint are missing
There was a problem hiding this comment.
Already added them in later commit
There was a problem hiding this comment.
I mean those are are not parts of all.
BTW, do you want to add tasks for c# client too?
There was a problem hiding this comment.
There are no tasks for testing server modules
| @@ -105,7 +105,7 @@ Before starting this step, make sure you've installed all software requirements. | |||
| git clone --branch ${VERSION} https://github.com/valkey-io/valkey-glide.git | |||
| cd valkey-glide | |||
| ``` | |||
| 2. Initialize git submodule: | |||
| 2. Initialize git submodules: | |||
There was a problem hiding this comment.
remove this from all docs - we don't need this anymore
| @@ -163,7 +163,7 @@ go test -race ./... -run TestConnectionRequestProtobufGeneration_allFieldsSet -v | |||
| After pulling new changes, ensure that you update the submodules by running the following command: | |||
|
|
|||
| ```bash | |||
| git submodule update | |||
| git submodule update --init --recursive | |||
| @@ -1,4 +1,5 @@ | |||
| # Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0 | |||
| # mypy: disable_error_code="arg-type" | |||
There was a problem hiding this comment.
Consider renaming the dir and updating readme.
| which redis-server | ||
|
|
||
| clean: | ||
| rm -fr .build/ |
There was a problem hiding this comment.
include cleaning for all clients + core there
This was referenced Oct 16, 2024
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
* Make redis-rs part of this repo * Improved PYTHON DEVELOPERS.md file * Added Makefile for unified build method for all the languages
avifenesh
pushed a commit
to avifenesh/valkey-glide
that referenced
this pull request
Oct 21, 2024
* Make redis-rs part of this repo * Improved PYTHON DEVELOPERS.md file * Added Makefile for unified build method for all the languages
Muhammad-awawdi-amazon
pushed a commit
to Muhammad-awawdi-amazon/valkey-glide
that referenced
this pull request
Oct 22, 2024
* Make redis-rs part of this repo * Improved PYTHON DEVELOPERS.md file * Added Makefile for unified build method for all the languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the above:
Makefilefor building all bindingspythonDEVELOPER.mdfilepython.ymlusing the proper solution for fixing installation of toolsWith the new
Makefile, one can run:In order to build, lint & test java:
This is also supported for
python,nodeandgoTo get a full list of possible
Makefiletargets:make helpLinked issue: #2450