Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python FT.DROPINDEX command #2437

Merged
merged 14 commits into from
Oct 15, 2024
Merged

Python FT.DROPINDEX command #2437

merged 14 commits into from
Oct 15, 2024
+116 −48

Conversation

prateek-kumar-improving
Copy link
Collaborator

@prateek-kumar-improving prateek-kumar-improving commented Oct 11, 2024 •
edited
Loading

Issue link

This Pull Request is linked to issue (URL): #2429

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

@prateek-kumar-improving
Python [FT.DROPINDEX] Added command
6351a9e 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python [FT.DROPINDEX] Add examples
29b5881 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving prateek-kumar-improving requested a review from a team as a code owner October 11, 2024 17:06
@prateek-kumar-improving prateek-kumar-improving mentioned this pull request Oct 11, 2024
Open
16 tasks
@prateek-kumar-improving prateek-kumar-improving changed the title Python ft dropindex Python FT.DROPINDEX command Oct 11, 2024
@prateek-kumar-improving
Updated CHANGELOG.md
20c0c32 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
jamesx-improving
jamesx-improving approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved if comment addressed.

@prateek-kumar-improving
Python [FT.DROPINDEX] Update documentation
efdf4ae 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python [FT.DROPINDEX] documentation updated
0e98fbb 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python [FT.DROPINDEX] Update return documentation
26435d8 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Review comments fixed
03e35be 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python FT.CREATE related code cleanup
0263813 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python ft_constants.py file moved to options
c2f904c 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@prateek-kumar-improving
Python ft_constants.py reformatted
27c4539 
Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
@acarbonetto acarbonetto merged commit 23a180b into release-1.2 Oct 15, 2024
12 checks passed
@acarbonetto acarbonetto deleted the python-ft-dropindex branch October 15, 2024 18:33
@prateek-kumar-improving prateek-kumar-improving changed the title Python FT.DROPINDEX command Python FT.DROPINDEX command Oct 17, 2024
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@prateek-kumar-improving @avifenesh
Python FT.DROPINDEX command (valkey-io#2437)
0670a6e 
* Python [FT.DROPINDEX] Added command

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
avifenesh pushed a commit to avifenesh/valkey-glide that referenced this pull request Oct 21, 2024
@prateek-kumar-improving @avifenesh
Python FT.DROPINDEX command (valkey-io#2437)
de7d47a 
* Python [FT.DROPINDEX] Added command

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Muhammad-awawdi-amazon pushed a commit to Muhammad-awawdi-amazon/valkey-glide that referenced this pull request Oct 22, 2024
@prateek-kumar-improving @Muhammad-awawdi-amazon
Python FT.DROPINDEX command (valkey-io#2437)
63d2c59 
* Python [FT.DROPINDEX] Added command

---------

Signed-off-by: Prateek Kumar <prateek.kumar@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acarbonetto acarbonetto acarbonetto approved these changes

@shohamazon shohamazon shohamazon left review comments

@jamesx-improving jamesx-improving jamesx-improving approved these changes

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prateek-kumar-improving @acarbonetto @shohamazon @jamesx-improving