Fix issues in CI #32
Merged
Fix issues in CI #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A similar Windows build is already covered by the workflow "Build and test". Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
The setting is already enabled in the main CMakeLists.txt. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
PLATFORM_FLAGS is not set on built binaries i.e. tests. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Use latest available gcc/clang in workflow "CI" and only build with one older version each. Includes some clean-ups. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Issue found in CMake builds on macOS in CI. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
michael-grunder
approved these changes
Jun 27, 2024
|
The macOS |
michael-grunder
pushed a commit
to michael-grunder/libvalkey
that referenced
this pull request
Aug 1, 2024
Fixes most remaining issues in CI to get most jobs green. - Enable building non-cluster test on FreeBSD in CI. - Don't run tests on Windows in CI workflow "CI". - CMake correction for libevent header. - Update compilers in CI build matrix. Use latest available gcc/clang in workflow "CI". - Fix 32bit build in CI workflow "C/C++ CI". Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes most remaining issues in CI (hopefully) to get most jobs green.
Use latest available gcc/clang in workflow "CI"
Known issue left:
ci.yml: Run static checkers - clang-format needed to make it happy.build.yml: Intermittent timing issue in test onmacOS.Then additional fixes are required, like updating Actions to remove Github warnings,
and merging of CI jobs, some are redundant..
Other finding:
PLATFORM_FLAGSis not set on built binaries i.e. tests.