Remove support for splitting multi-key commands per slot #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Rename and remove unnecessary checks in internal function: command_format_by_slot(). Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
bjosv
force-pushed
the
remove-multislot-support
branch
from
64da016
to
c92d39b
Compare
zuiderkwast
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
This is great.
There's some clang-format issue.
I believe some users, at least of other clients in other languages, want this feature to do mass inserts. I don't think it's worth the complexity and the broken atomicity expectations though. If they want to do mass insertions, they can partition their keys by slot themselves (using valkeyClusterGetSlotByKey) and compose their own mset commands, or use some other tool for mass insertions.
michael-grunder
pushed a commit
to michael-grunder/libvalkey
that referenced
this pull request
Aug 1, 2024
- Remove support for command splitting in cluster API Since old days (from hiredis-vip) there has been support for sending some commands that contains multiple keys, but which covers multiple slots. The client would split a command into multiple commands and send to each node handling each slot. This is unnecessary complex, so lets remove it in this early stage. - Refactor function that prepares cluster commands Rename and remove unnecessary checks in the internal function `command_format_by_slot()`. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for command splitting in cluster API
Since old days (from hiredis-vip) there has been support for sending some commands that contains multiple keys, but which covers multiple slots. The client would split a command into multiple commands and send to each node handling each slot.
This is unnecessary complex, so lets remove it in this early stage.
Refactor function that prepares cluster commands
Rename and remove unnecessary checks in the internal function
command_format_by_slot().