Fix ISO C naming violations of function names and header guards #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuiderkwast
reviewed
Jun 27, 2024
libvalkeycluster/tests/test_utils.h
Outdated
| @@ -1,5 +1,5 @@ | |||
| #ifndef __TEST_UTILS_H__ | |||
There was a problem hiding this comment.
Why add VALKEY to each of these? Do you think there's a risk of macro name collission?
There was a problem hiding this comment.
Probably no collision in src/, I mostly followed how its done in the non-cluster headers.
src/async_private.h: #ifndef VALKEY_ASYNC_PRIVATE_H
src/fmacros.h: #ifndef VALKEY_FMACRO_H
One (only?) benefit I can think of is that its already correct if we need to make a header public.
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
zuiderkwast
approved these changes
Jul 1, 2024
michael-grunder
pushed a commit
to michael-grunder/libvalkey
that referenced
this pull request
Aug 1, 2024
…ey-io#21) * Update header guards after move of header files * Fix ISO-C naming violation by renaming internal functions: * ..SetError() * _valkeyClusterConnect() * __valkeyClusterAppendCommand() * __valkeyClusterGetReplyFromNode() * Remove internal func __valkeyClusterGetReply() * Remove internal func _valkeyClusterConnect2() Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19