Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor slotmap update functions #107

Merged
merged 7 commits into from
Oct 4, 2024
Merged

Refactor slotmap update functions #107

merged 7 commits into from
Oct 4, 2024

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Oct 3, 2024

  • Merge handleClusterSlotsReply and handleClusterNodesReply into clusterUpdateRouteHandleReply.
    • Validate the reply in parse_cluster_slots and parse_cluster_nodes
    • Remove redundant argument flags in parse_cluster_slots and parse_cluster_nodes
  • Use error strings from the standalone context in both the send function (clusterUpdateRouteSendCommand) and the response function (handleClusterSlotsReply); making sure that specific error strings are used (like OOM).
  • Update OOM test which now get correct error string.

@bjosv
Refactor parse_cluster_nodes to accept a valkeyReply
8c59d04 
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv
Refactor validation of cluster slots/nodes reply
ae2a0e3 
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv
Return OOM errors from parse_cluster_nodes
23b405a 
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv
Return context error strings from clusterUpdateRouteSendCommand
1f41dc1 
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv
Refactor clusterUpdateRouteHandleReply
f6bf90f 
Merge handleClusterSlotsReply and handleClusterNodesReply into
clusterUpdateRouteHandleReply.

Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv
Check connect error string in OOM tests
ffc1515 
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv
Remove redundant argument in parse_cluster_slots and parse_cluster_nodes
fe4a044 
Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
@bjosv bjosv force-pushed the refactor-slotmap-update-internals branch from 9dcda0b to fe4a044 Compare October 3, 2024 10:36
@bjosv bjosv requested a review from zuiderkwast October 3, 2024 10:45
zuiderkwast
zuiderkwast approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjosv bjosv merged commit 1d9e49c into valkey-io:main Oct 4, 2024
34 checks passed
@bjosv bjosv deleted the refactor-slotmap-update-internals branch October 4, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zuiderkwast zuiderkwast zuiderkwast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjosv @zuiderkwast