test: fix MenuAccessControl mocking #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mock object should call MenuAccessControl.canAccessView default method, that also requires VaadinRequest thread local to be set.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2863 +/- ##
=======================================
Coverage 92.64% 92.64%
=======================================
Files 83 83
Lines 2840 2840
Branches 728 728
=======================================
Hits 2631 2631
Misses 157 157
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cromoteca
approved these changes
Oct 24, 2024
ZheSun88
pushed a commit
that referenced
this pull request
Oct 24, 2024
* test: fix MenuAccessControl mocking Mock object should call MenuAccessControl.canAccessView default method, that also requires VaadinRequest thread local to be set. * format
ZheSun88
pushed a commit
that referenced
this pull request
Oct 24, 2024
test: fix MenuAccessControl mocking (#2863) * test: fix MenuAccessControl mocking Mock object should call MenuAccessControl.canAccessView default method, that also requires VaadinRequest thread local to be set. * format Co-authored-by: Marco Collovati <marco@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock object should call MenuAccessControl.canAccessView default method, that also requires VaadinRequest thread local to be set.