Propagate type annotations in the exact matcher #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges in the readme
* [ add ] vat_matmul runtime files * [ update ] get rid of pushing 0s to ACC * add comment about the change in codegen.cc * restore ACC buffer initialization * [ add ] compute missing fields of VTA config
…3la-pldi-push-main
gussmith23
approved these changes
Dec 15, 2021
|
@slyubomirsky can you check that my merge conflict resolution is correct? and then can you merge this? |
gussmith23
force-pushed
the
3la-pldi-push-main
branch
from
dc9ee6d
to
17bde2c
Compare
slyubomirsky
requested review from
jroesch,
tmoreau89,
tqchen and
vegaluisjose
as code owners
gussmith23
force-pushed
the
3la-pldi-push-main
branch
from
405c123
to
4b1858b
Compare
gussmith23
force-pushed
the
3la-pldi-push-main
branch
from
9d5a9ec
to
82699db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a small but potentially useful feature to the exact matcher: If the checked types have already been filled in for the target program, this will add in type annotations to the inserted functions. This should address the bug we ran into with type checking on LSTM (don't know the root cause on that).
Please review @AD1024 @gussmith23