Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some miscelenious issues encountered while working on #335 #339

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

Ngalstyan4
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 commented Jan 14, 2024

Fix some miscelenious issues encountered while working on #335

  1. Add move construction tests and fix an issue caused by them
    ASAN flagged the memset call on empty buffer when the test ran with the added move construction portion

  2. Only consider zero length IO an error if input buffer was larger than zero

  3. Move option-override policy opt-in before policy definitions so overr…

@ashvardanian
Copy link
Contributor

Great fixes, @Ngalstyan4! Also, thank you a lot for organizing the suggestions in separate PRs, always supported by evidence! Always joy reading them 🤗

@ashvardanian ashvardanian merged commit 4747ef4 into unum-cloud:main-dev Jan 14, 2024
1 of 5 checks passed
@Ngalstyan4 Ngalstyan4 deleted the narek/move-construction branch January 14, 2024 06:49
@ashvardanian ashvardanian mentioned this pull request Jan 19, 2024
2 tasks
Ngalstyan4 added a commit to Ngalstyan4/usearch that referenced this pull request Feb 5, 2024
* Add move construction tests and fix an issue caused by them

* Only consider zero length IO an error if input buffer was larger than zero

* Move option-override policy opt-in before policy definitions so overrides actually take effect
ashvardanian pushed a commit that referenced this pull request Feb 22, 2024
# [2.9.0](v2.8.16...v2.9.0) (2024-02-22)

### Add

* SQLite binding ([222de55](222de55))
* String distances to SQLite ([ae4d0f0](ae4d0f0))

### Docs

* Header refreshed ([7465c29](7465c29))
* Py and SQLite extensions ([550624b](550624b))
* README.md link to Joins (#327) ([1279c54](1279c54)), closes [#327](#327)

### Fix

* bug reports were immediately marked invalid ([c5fc825](c5fc825))
* Error handling, mem safety bugs #335 (#339) ([4747ef4](4747ef4)), closes [#335](#335) [#339](#339)
* Passing SQLite tests ([6334983](6334983))
* Reported number of levels ([9b1a06a](9b1a06a))
* Skip non-Linux SQLite tests ([b02d262](b02d262))
* SQLite cosine function + tests ([55464fb](55464fb))
* undefined var error in `remove` api ([8d86a9e](8d86a9e))

### Improve

* Multi property lookup ([e8bf02c](e8bf02c))
* Support multi-column vectors ([66f1716](66f1716))

### Make

* `npi ci` (#330) ([5680920](5680920)), closes [#330](#330)
* Add 3.12 wheels ([d66f697](d66f697))
* Change include paths ([21db294](21db294))
* invalid C++17 Clang arg ([2a6d779](2a6d779))
* Link libpthread for older Linux GCC builds (#324) ([6f1e5dd](6f1e5dd)), closes [#324](#324)
* Parallel CI for Python wheels ([a9ad89e](a9ad89e))
* Upgrade SimSIMD & StringZilla ([5481bdf](5481bdf))

### Revert

* Postpone Apache Arrow integration ([5d040ca](5d040ca))
@ashvardanian
Copy link
Contributor

🎉 This PR is included in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants