Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution guide improvment #23

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Contribution guide improvment #23

wants to merge 3 commits into from
+30 −0

Conversation

nathan-de-pachtere
Copy link
Contributor

Add a section about props inside the contribution guide, it's a suggestion to standardize the way component are defined.

rahul-vashishtha
rahul-vashishtha reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@rahul-vashishtha rahul-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know your thoughts if we use types over interfaces

content/1.getting-started/3.contribution.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-vashishtha rahul-vashishtha rahul-vashishtha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathan-de-pachtere @rahul-vashishtha