fix(node): preserve http number header type with setHeader (#119)

Co-authored-by: Pooya Parsa <pooya@pi0.io>
unjs · Aug 2, 2023 · bd09775 · bd09775
1 parent b872b02
commit bd09775
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/src/runtime/fetch/index.ts b/src/runtime/fetch/index.ts
@@ -20,7 +20,7 @@ export function createFetch(call: CallHandle, _fetch = global.fetch) {
  headers: Object.fromEntries(
  Object.entries(r.headers).map(([name, value]) => [
  name,
- Array.isArray(value) ? value.join(",") : value || "",
+ Array.isArray(value) ? value.join(",") : String(value) || "",
  ]),
  ),
  });

diff --git a/src/runtime/node/http/_response.ts b/src/runtime/node/http/_response.ts
@@ -22,7 +22,7 @@ export class ServerResponse extends Writable implements http.ServerResponse {
 
  req: http.IncomingMessage;
 
- _headers: HeadersObject = {};
+ _headers: Record<string, number | string | string[] | undefined> = {};
 
  constructor(req: http.IncomingMessage) {
  super();
@@ -91,11 +91,8 @@ export class ServerResponse extends Writable implements http.ServerResponse {
  return this;
  }
 
- setHeader(
- name: string,
- value: number | string | ReadonlyArray<string>,
- ): this {
- this._headers[name.toLowerCase()] = value + "";
+ setHeader(name: string, value: number | string | string[]): this {
+ this._headers[name.toLowerCase()] = value;
  return this;
  }