feat(internal): Pass 8 CSPRNG random integer words #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderjung
reviewed
Sep 23, 2024
craciunoiuc
force-pushed
the
craciunoiuc/random-rng
branch
from
e92dc44
to
28df6c4
Compare
nderjung
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
All good on my side implementation-wise. Thanks!
Regarding the interaction with Unikraft itself, I'd like to cc @razvand and @michpappas before merging to help verify everything in conjunction with unikraft/unikraft#1496
craciunoiuc
force-pushed
the
craciunoiuc/random-rng
branch
from
28df6c4
to
1429fe9
Compare
|
Updated to check for RDRAND/RDSEED If they are both present then ignore the config option and let Unikraft take its own bytes from the device/generator |
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/random-rng
branch
from
1429fe9
to
e7925f2
Compare
Depends-on: unikraft/unikraft#1496 Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
craciunoiuc
force-pushed
the
craciunoiuc/random-rng
branch
from
e7925f2
to
5771822
Compare
craciunoiuc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes