Enable longer/secure password on user account registration #1452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istride
reviewed
Mar 28, 2023
iogt/static/css/accounts.css
Outdated
| @@ -95,3 +95,8 @@ form input[type="checkbox"] { | |||
| font-weight: 500; | |||
| line-height: 14px; | |||
| } | |||
|
|
|||
| .fieldWrapper input[type=checkbox] { | |||
| transform: translateY(3px); | |||
There was a problem hiding this comment.
This seems weird to me. Why use transform instead of, say, margin or padding?
| @@ -32,10 +39,10 @@ class AccountSignupForm(SignupForm): | |||
| def __init__(self, *args, **kwargs): | |||
| super(AccountSignupForm, self).__init__(*args, **kwargs) | |||
| self.fields.pop('email') | |||
| self.fields["password1"] = IogtPasswordField(label=_("4-digit PIN"), autocomplete="new-password") | |||
| self.fields["password1"] = IogtPasswordField(label=_("Enter a 4-digit PIN or a longer password"), autocomplete="new-password") | |||
There was a problem hiding this comment.
I think this will have to be re-translated. I've asked whether this should be done now or as a separate issue.
Alihassanc5
force-pushed
the
enh/enable-longer-password
branch
from
7dfb781
to
7bf59a1
Compare
|
@cbunicef you can take the translations.csv from this to add translations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1391
Closes #1392
Change Password
