Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for latest Elden Ring patch (1.12 Shadow of the Erdtree) and include new options for ultrawide #147

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AmbiguousInteractive
Copy link

@AmbiguousInteractive AmbiguousInteractive commented Jun 14, 2024

  • Fix so it no longer crashes the game
  • Fix ultrawide not working correctly
  • Added option for animations to extend upon the new removed black bar areas
  • Added auto-run option: Add 'auto start' option #129
  • Support for Patch 1.12 (Shadow of the Erdtree)

If you want Full screen and/or HDR support, you'll need this mod: https://www.nexusmods.com/eldenring/mods/4513?tab=description
Once installed, open the interface in-game (its a small window), click on view (top of the small window) -> advanced settings -> Override FullScreen State after which you must restart the game. Then set your game to fullscreen and enable HDR. It won't be locked to 60hz in-game anymore.

@AmbiguousInteractive AmbiguousInteractive changed the title Fix for latest Elden Ring patch and include new options for ultrawide Fix for latest Elden Ring patch (1.12 Shadow of the Erdtree) and include new options for ultrawide Jun 20, 2024
@gabepesco
Copy link

Hey @AmbiguousInteractive, it looks like on game version 2.2.0.0, the frame rate lock only works in the borderless windowed and windowed modes, and not fullscreen. I'm happy to test out changes and contribute some updates from some of the other branches to your repo, if you're interested.

@AmbiguousInteractive
Copy link
Author

Hey @AmbiguousInteractive, it looks like on game version 2.2.0.0, the frame rate lock only works in the borderless windowed and windowed modes, and not fullscreen. I'm happy to test out changes and contribute some updates from some of the other branches to your repo, if you're interested.

Hey don't worry everything I'll push here. I pushed some fixes for full screen and other stuff so check it out and let me know if it works

@gabepesco
Copy link

gabepesco commented Jun 21, 2024

@AmbiguousInteractive Pulled your repo again and still seeing the same issue of the FPS cap change only applying in the borderless windowed and windowed modes. I confirmed that the changes you made to GameData.cs from your most recent commit were present before compiling the build. Happy to keep trying new versions.

Edit: I played around with CE and I can find the aob's for PATTERN_HERTZLOCK and PATTERN_FRAMELOCK_FUZZY, but not PATTERN_FRAMELOCK. That includes replacing the fourth byte (89) with 88/90/??, so I think the PATTERN_FRAMELOCK aob is the most likely culprit. Running with debug in VS, I'm seeing fFrameTick found at: 0x2 in the output, which doesn't look right.

@AmbiguousInteractive
Copy link
Author

@AmbiguousInteractive Pulled your repo again and still seeing the same issue of the FPS cap change only applying in the borderless windowed and windowed modes. I confirmed that the changes you made to GameData.cs from your most recent commit were present before compiling the build. Happy to keep trying new versions.

Edit: I played around with CE and I can find the aob's for PATTERN_HERTZLOCK and PATTERN_FRAMELOCK_FUZZY, but not PATTERN_FRAMELOCK. That includes replacing the fourth byte (89) with 88/90/??, so I think the PATTERN_FRAMELOCK aob is the most likely culprit. Running with debug in VS, I'm seeing fFrameTick found at: 0x2 in the output, which doesn't look right.

Yeah its odd, I tried my best gotta wait for other people more familiar with disassembly to fix this one.

@nikolaJosifovic
Copy link

Can I download from somewhere fixed version?
I think that owner of this repo is not managing it anymore.
Or if someone can write steps how to compile it.

Thanks

@Okazakee
Copy link

Can I download from somewhere fixed version? I think that owner of this repo is not managing it anymore. Or if someone can write steps how to compile it.

Thanks

up

@AmbiguousInteractive
Copy link
Author

If you want Full screen and/or HDR support, you'll need this mod: https://www.nexusmods.com/eldenring/mods/4513?tab=description
Once installed, open the interface in-game (its a small window), click on view (top of the small window) -> advanced settings -> Override FullScreen State after which you must restart the game. Then set your game to fullscreen.

Thanks to gurrgur/er-patcher#74 (comment) for the information

@RenegadeWraith
Copy link

All that mod does it turn Fullscreen into a modified Borderless mode. Same thing with the Special K mod. So while HDR works, it's not true fullscreen. Still waiting on a true fix for Fullscreen FPS uncap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants