Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support to pass empty string params #609

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Certain endpoints allow sending empty value in the string sids. But we are preventing it from cli. Removing that check to allow passing such values. In case of error, we'll show server error and not 4XX.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 merged commit b1fce3a into main Sep 27, 2024
10 checks passed
@tiwarishubham635 tiwarishubham635 deleted the add-support-for-empty-string-params branch September 27, 2024 08:43
twilio-dx pushed a commit that referenced this pull request Oct 3, 2024
## [5.22.3](5.22.2...5.22.3) (2024-10-03)

### Library - Chores

* add support to pass empty string params ([#609](#609)) ([b1fce3a](b1fce3a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants