Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calendar] Removes bottom nav bar #7387

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

andrehgdias
Copy link
Contributor

This commit removes the bottom nav bar from all views and adds a new floating action button to handle event creation.
To allow navigation between views without a bottom navbar, a calendar icon has been added on the top right.

Closes #7366

@andrehgdias andrehgdias linked an issue Aug 14, 2024 that may be closed by this pull request
6 tasks
Copy link
Contributor

@wrdhub wrdhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test notes would be appreciated too.

src/calendar-app/calendar/view/CalendarRow.ts Outdated Show resolved Hide resolved
@andrehgdias andrehgdias force-pushed the 7366-remove-the-bottom-nav-bar branch 2 times, most recently from 87fedd1 to d0171a2 Compare August 16, 2024 13:52
This commit removes the bottom nav bar from all views and adds a new
floating action button to handle event creation.
To allow navigation between views without a bottom navbar, a
calendar icon has been added on the top right.

Co-authored-by: mup <34790144+murilopereirame@users.noreply.github.com>
@andrehgdias andrehgdias force-pushed the 7366-remove-the-bottom-nav-bar branch from d0171a2 to 1e7365c Compare August 16, 2024 13:52
@andrehgdias andrehgdias merged commit 1e7365c into dev-calendar Aug 16, 2024
1 check passed
@andrehgdias andrehgdias deleted the 7366-remove-the-bottom-nav-bar branch August 16, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the bottom nav bar
2 participants