Fix the credit card verification #7376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-hub
approved these changes
Aug 13, 2024
| } | ||
| } | ||
| throw new Error(`no such iOS plan ${planName}`) | ||
| } else { | ||
| const displayPrice = formatPrice(price, true) | ||
| return { displayPrice, rawPrice: rawPrice.toString() } |
There was a problem hiding this comment.
Suggested change
| return { displayPrice, rawPrice: rawPrice.toString() } | |
| return { displayPrice, rawPrice } |
There was a problem hiding this comment.
Good catch, I will change it.
| case PaymentInterval.Yearly: | ||
| return mobilePlan.yearlyPerYear | ||
| return { displayPrice: mobilePlan.yearlyPerYear, rawPrice: rawPrice.toString() } |
There was a problem hiding this comment.
Suggested change
| return { displayPrice: mobilePlan.yearlyPerYear, rawPrice: rawPrice.toString() } | |
| return { displayPrice: mobilePlan.yearlyPerYear, rawPrice } |
| if (isIOSApp()) { | ||
| const planName = PlanTypeToName[subscription] | ||
| const mobilePlan = this.getMobilePrices().get(planName.toLowerCase()) | ||
| if (mobilePlan) { | ||
| switch (paymentInterval) { | ||
| case PaymentInterval.Monthly: | ||
| return mobilePlan.monthlyPerMonth | ||
| return { displayPrice: mobilePlan.monthlyPerMonth, rawPrice: rawPrice.toString() } |
There was a problem hiding this comment.
You already have rawPrice as a string, so you needn't convert it again.
Suggested change
| return { displayPrice: mobilePlan.monthlyPerMonth, rawPrice: rawPrice.toString() } | |
| return { displayPrice: mobilePlan.monthlyPerMonth, rawPrice } |
This fixes the currency symbol being included and the decimal separator in the call to the Braintree card verification causing it to fail. It is not possible to have `getSubscriptionPriceWithCurrency` return without currency formatting because the return of `getPlanPrices` cannot be changed as `StoreKit` can only return the price in the local currency. Closes #7370. Co-authored-by: wec <wec@tutao.de>
rezbyte
force-pushed
the
7370-invalid-card-verification
branch
from
da15044
to
6832af6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the currency symbol being included and the decimal separator in the call to the Braintree card verification causing it to fail.
It is not possible to have
getSubscriptionPriceWithCurrencyreturn without currency formatting because the return ofgetPlanPricescannot be changed asStoreKitcan only return the price in the local currency.Closes #7370.