Fix key error after the first login #7359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wec43
reviewed
Aug 9, 2024
We have added a migration to add `encryptedPassphraseKey` and we've been erroneously calling `getDecryptedCredentialsByUserId()` before any credentials have been stored. Now we first make sure that the credentials are there and then we try to fetch and decrypt them. fix #7330
charlag
force-pushed
the
fix-key-error-after-login-7330
branch
from
8ad45ba
to
8e8f2c0
Compare
|
rebased |
wec43
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added a migration to add
encryptedPassphraseKeyand we've been erroneously callinggetDecryptedCredentialsByUserId()before any credentials have been stored.Now we first make sure that the credentials are there and then we try to fetch and decrypt them.
fix #7330