7216 default calendar reminder #7346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rih-tutao
force-pushed
the
7216-default-calendar-reminder
branch
4 times, most recently
from
2d9ed64
to
83e6939
Compare
wrdhub
approved these changes
Aug 14, 2024
This commit adds a new feature that allows users to set multiple default reminders at each calendar, either shared or private. These reminders are unique for each user's calendar. Co-authored-by: rih <rih@tutao.de> Co-authored-by: Murilo Rocha Pereira <34790144+murilopereirame@users.noreply.github.com>
This commit removes the recently added feature that allows users to set multiple default reminders from not owned shared calendars. These reminders are unique for each user's calendar and should not be available for shared calendars the user don't own. CalendarInfo.userIsOwner was introduced, so we could keep using the CalendarInfo.shared field to preserve the current behavior(v235.240718.0) when dealing with selecting calendars. This commit also rewrites some of the logic related to CalendarInfo.shared, which affects calendar sharing, calendar list(on the sidebar) and event invites,especially the capabilities a user has when editing an event.
rih-tutao
force-pushed
the
7216-default-calendar-reminder
branch
from
83e6939
to
4f48ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new feature that allows users to set multiple default reminders at each calendar, either shared or private. These reminders are unique for each user's calendar.
Closes #7216
Re-implements #7226 but saves on the merge hassle