Branding/logo adjustments #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murilopereirame
approved these changes
Jun 28, 2024
|
@dgrafhub had some more thoughts and said that dark theme one should also be monochrome so we'll change that too |
wec43
reviewed
Jul 9, 2024
| @@ -133,6 +132,11 @@ export function getNavigationMenuIcon(): string { | |||
| return theme.navigation_menu_icon || theme.navigation_button_icon | |||
There was a problem hiding this comment.
The function will always return navigation_menu_icon now I think?
We do not want to color our logo in random colors so for whitelabel themes it will be monochrome version of our logo by default. Same goes for blue theme. About dialog was missing some space for the logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages