fix cloudfront_distribution_use_secure_cipher protocol filter #827
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The query
cloudfront_distribution_use_secure_cipher
uses a where clause that does not match with resources that should be correct.From AWS docs allowed values are
SSLv3
,TLSv1
,TLSv1.1
andTLSv1.2
. The chosen value is the minimum SSL protocol that CloudFront uses with the origin. TheCustomOriginConfig.OriginSslProtocols.Items
value will contain all allowed protocols, so choosingSSLv3
will result in["SSLv3", "TLSv1", "TLSv1.1", "TLSv1.2"]
.Valid origins are those that contain neither
SSLv3
norTLSv1
.I have added the
distinct
statement as a distribution using two or more origins, one withSSLv3
and one withTLSv1
, would return two results.Checklist