Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: automatically generate a self-signed certificate #1255

Closed
wants to merge 1 commit into from

Conversation

lonnywong
Copy link
Contributor

Automatically generate a self-signed certificate if ssl is enabled and no certificate and key files are specified.

@lonnywong lonnywong marked this pull request as draft November 20, 2023 14:49
if ssl is enabled and no certificate and key files are specified.
@lonnywong
Copy link
Contributor Author

@tsl0922 Can you rerun the tests? All tests should succeed.

@morph027
Copy link

Oh, thank you, just tested this PR successully 🎉 😍

@tsl0922
Copy link
Owner

tsl0922 commented Mar 5, 2024

Why? I think it is outside the scope of this project.

I would recommend using tools like mkcert or cfssl if you don't like openssl cli in SSL Usage.

@tsl0922 tsl0922 closed this Mar 5, 2024
@lonnywong
Copy link
Contributor Author

Why? I think it is outside the scope of this project.

I would recommend using tools like mkcert or cfssl if you don't like openssl cli in SSL Usage.

It will be much more convenient when you need to use https temporarily, without having to read the manual of other tools.

@tsl0922
Copy link
Owner

tsl0922 commented Mar 5, 2024

It introduces maintenance cost in this project, and I'm not a security expert on SSL, so it won't be merged here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants