Use enums instead of string constants #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used String<_> to represent string constants in some responses. This has multiple drawbacks: - It is error-prone because the value is not validated. - Construction is fallible because of the fixed length of the string. - The length needs to be bumped if longer values are added. This patch introduces enums to replace these constants. As cbor_smol serializes enums using the variant index instead of the string, we need to manually implement the string conversion.
sosthene-nitrokey
approved these changes
Jun 24, 2024
These tests makes sure that the serialization of the new enums works correctly, and also help to detect accidental changes to the field order used by serde_indexed in the response struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
String<_>to represent string constants in some responses. This has multiple drawbacks:This patch introduces enums to replace these constants. As
cbor_smolserializes enums using the variant index instead of the string, we need to manually implement the string conversion.