-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test all input-files with short line-breaks #338
base: master
Are you sure you want to change the base?
Test all input-files with short line-breaks #338
Conversation
Thanks for these |
I can create issues for the unfixed issues of course. But the unit-test will still fail, since it is a generic one that detects all five issues. |
About the failing check: |
Thank you Max for fixing the build. Now it's only the failing unit-test that makes the checks fail. |
I can probably fix the async thing later, I'll add it to this pr |
Is something missing in our request? Do you have a timeframe for the next release? |
I'll take a look later, apologies |
When I come to run the tests for this I get:
Nuget Restore doesn't fix this, is this right? Am I missing something? |
Some references in Nuglify.Tests.nuget.props depends from windows user profile and nugget version. This changes are not pushed.
|
Please try it again with the new commit. It contains a new file NUglify.Tests.nuget.props. |
So, the tests fail, as per AppVeyor |
Which tests fail? We only fixed 2 of 4 problems for linebreaks, now the 2 others run into an error. The other failing tests we dont touched. |
Just to avoid misunderstandings: TLDR: |
While using this library, we got some issues with line-breaks that are just waiting to occur in the real world.
After the second issue, we wrote a generic unit test.
This test takes all input files, minifies them with "-line:1" and tries to execute the minified code using the Microsoft.ClearScript-Engine. We found a total of four distinct issues when it comes to line-breaks:
Additionally, the expected output for "ES6.js" simply does not compile and should be fixed.
Of course, the test ignores all js-files that are invalid from the start (e.g. because of placeholders).
How should we proceed with this?
Please find the current output of the test attached.
Test Output for SyntaxTestForAllFilesLineBreaks.Hipigog.txt