NAS-127228 / 25.04 / Add system version to About dialog #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugclerk
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10910 +/- ##
==========================================
+ Coverage 81.91% 81.92% +0.01%
==========================================
Files 1597 1597
Lines 56317 56323 +6
Branches 5842 5843 +1
==========================================
+ Hits 46131 46144 +13
+ Misses 10186 10179 -7 ☔ View full report in Codecov by Sentry. |
undsoft
approved these changes
Oct 22, 2024
| <div><ix-icon name="verified_user" class="bullet-icon"></ix-icon></div> | ||
| <div | ||
| class="medium-font" | ||
| [innerHtml]="('System Version' | translate) + ': ' + (systemVersion$ | async)" |
There was a problem hiding this comment.
[innerHtml] appears to be unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
See ticket & results:
Tests added.
Downstream