Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci-tooling and config files #7

Merged
merged 24 commits into from
Jul 12, 2024
Merged

add ci-tooling and config files #7

merged 24 commits into from
Jul 12, 2024

Conversation

stavros-k
Copy link
Contributor

@stavros-k stavros-k commented May 14, 2024

Supersedes #4

  • removed the need of the additional go tool for checking container's health.
  • now for each test file in each changed app, a new job will spin. that has some benefits:
    • parallel runs, (no more waiting an hour or even more for apps like minecraft or immich)
    • clean workspace for each test (so we can avoid parsing compose files to identify host paths used to clean them before the next run)
  • There are 2 python scripts that are probably hideous to look at. But I figured python would be easier for others to chime in and improve things later.
  • I've placed a max of 10 jobs in parallel to avoid hammering github :D.

Currently the ci.py script does 2 modifications during its runtime:

  • Copies the top-level library to the app-level based on the app.yaml lib_version field.
  • Copies the top-level macros to the app-level.

If we add those 2 steps in a release script we might want to extract them and re-use them

@stavros-k
Copy link
Contributor Author

Please if anyone got a spare moment and want to take over/refactor this. Please do :)
I'm sure there are a ton of better ways to do all this with python-isms

@stavros-k stavros-k force-pushed the ci-tooling branch 3 times, most recently from 5748115 to dd73e43 Compare June 26, 2024 13:11
.flake8 Outdated Show resolved Hide resolved
.github/scripts/ci.py Outdated Show resolved Hide resolved
.github/scripts/ci.py Outdated Show resolved Hide resolved
.github/scripts/ci.py Outdated Show resolved Hide resolved
.vscode/extensions.json Outdated Show resolved Hide resolved
@stavros-k stavros-k requested a review from Qubad786 July 12, 2024 11:23
Copy link
Contributor

@Qubad786 Qubad786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stavros-k stavros-k merged commit 65af312 into master Jul 12, 2024
3 checks passed
@stavros-k stavros-k deleted the ci-tooling branch July 12, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants