-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(test): improve tests coverage #6034
feat(test): improve tests coverage #6034
Conversation
@@ -2,12 +2,14 @@ plugins { | |||
id "org.gradle.test-retry" version "1.5.9" | |||
id "org.sonarqube" version "2.6" | |||
id "com.gorylenko.gradle-git-properties" version "2.4.1" | |||
id "io.github.surpsg.offlins" version "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of introducing this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To solve the incompatibility problem between jacoco and powermock
@@ -121,10 +123,12 @@ test { | |||
testLogging { | |||
exceptionFormat = 'full' | |||
} | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why annotate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the report part configuration of the offlinsCoverage module
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the default output path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default output path configured by offlinsCoverage is inconsistent with the original configuration of jacoco. In order to maintain the consistency of the coverage report document path.
framework/src/test/java/org/tron/common/logsfilter/TransactionLogTriggerCapsuleMockTest.java
Outdated
Show resolved
Hide resolved
framework/src/test/java/org/tron/common/logsfilter/TransactionLogTriggerCapsuleMockTest.java
Outdated
Show resolved
Hide resolved
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the Jacoco coverage of each module still be output locally after this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and the path is still the same
What does this PR do?
improve tests coverage
Why are these changes required?
This PR has been tested by:
Follow up
Extra details