feat(net): limit SR connections to relay nodes #5882
Merged
+66
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fyyhtx
approved these changes
Jun 25, 2024
halibobo1205
approved these changes
Jun 28, 2024
lvs007
approved these changes
Jul 1, 2024
yuekun0707
reviewed
Jul 1, 2024
| @@ -139,6 +141,13 @@ public boolean checkHelloMessage(HelloMessage message, Channel channel) { | |||
| return false; | |||
| } | |||
|
|
|||
| if (getPeerCountByAddress(msg.getAddress()) >= MAX_PEER_COUNT_PER_ADDRESS) { | |||
| logger.warn("HelloMessage from {}, the number of peers of {} exceeds 2.", | |||
There was a problem hiding this comment.
should add "equal to 2" here ?
There was a problem hiding this comment.
Should "2" be replaced with the variable "{MAX_PEER_COUNT_PER_ADDRESS}"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Limit the number of connections between an SR and relay nodes
Why are these changes required?
Avoid malicious witnesses from affecting the block propagation efficiency by establishing multiple connections with relay nodes.
This PR has been tested by:
Follow up
Extra details