Send table:import requests to api-import endpoints directly #226
Conversation
3 similar comments
tagomoris
force-pushed
the
send-table-import-requests-to-api-import-directly
branch
from
4a0d5af
to
bb0f0dd
Compare
tagomoris
force-pushed
the
send-table-import-requests-to-api-import-directly
branch
from
2bbf98c
to
beab44d
Compare
|
Updated the CI problems (and created #227 ) |
lib/td/command/runner.rb
Outdated
| @@ -94,6 +96,12 @@ def run(argv=ARGV) | |||
| endpoint = e | |||
| } | |||
|
|
|||
| op.on('-E', '--import-endpoint API_IMPORT_SERVER', "specify the URL for API Import server to use (default: https://api-import.treasuredata.com).") { |e| | |||
There was a problem hiding this comment.
Do you mean to use different character? (for example, -n?)
There was a problem hiding this comment.
Pushed a commit to use -i for "import".
@nurse How do you feel on it?
There was a problem hiding this comment.
I mean just remove one character option.
There was a problem hiding this comment.
Pushed the commit to remove it.
lib/td/command/runner.rb
Outdated
| @@ -140,6 +148,10 @@ def run(argv=ARGV) | |||
| Config.endpoint = endpoint | |||
| Config.cl_endpoint = true | |||
| end | |||
| if import_endpoint | |||
| Config.endpoint = endpoint | |||
There was a problem hiding this comment.
| Config.endpoint = endpoint | |
| Config.import_endpoint = import_endpoint |
|
@nurse Thanks! |
|
I think we should update import endpoint automatically (like workflow endpoint), if users will specify |
|
I agree I wish we have a REST API which returns endpoints |
|
How about having a JSON file for lists of TD public endpoints (for sites)? That can solve parts of problems, and it's not worse than the current situation (with just one default, |
|
Customers are already running |
|
Created #229 |
Now Treasure Data is providing
api-import.*endpoints only for streaming import requests.api.*endpoints can route/process those requests now and in future, but it's better to send those requests toapi-importendpoints.