test are running but failing badly

.eslintrc.js

@@ -351,7 +351,6 @@ module.exports = {
  triggerCopyError: true,
  signInUser: true,
  withFeature: true,
- percySnapshot: true,
  waitForElement: true
  },
  plugins: ['node'],

app/adapters/build.js

@@ -1,10 +1,10 @@
 import V3Adapter from 'travis/adapters/v3';
-import Ember from 'ember';
+import { testing } from 'ember';
 
 let includes = 'build.commit,build.branch,build.request,build.created_by';
 
 // TODO this is a workaround for an infinite loop in Mirage serialising 😞
-if (!Ember.testing) {
+if (testing) {
  includes += ',build.repository';
 }
 

app/app.js

@@ -1,6 +1,6 @@
 /* global Travis */
 import Evented from '@ember/object/evented';
-
+import Ember from 'ember';
 import Application from '@ember/application';
 import Resolver from './resolver';
 import loadInitializers from 'ember-load-initializers';

app/components/broadcast-tower.js

@@ -1,7 +1,7 @@
 import { later } from '@ember/runloop';
 import { Promise as EmberPromise } from 'rsvp';
 import Component from '@ember/component';
-import Ember from 'ember';
+import {testing} from 'ember';
 import { task } from 'ember-concurrency';
 
 export default Component.extend({
@@ -16,7 +16,7 @@ export default Component.extend({
  this.toggleBroadcasts();
 
  // Acceptance tests will wait for the promise to resolve, so skip in tests
- if (this.isOpen && !Ember.testing) {
+ if (this.isOpen && !testing) {
  yield new EmberPromise(resolve => later(resolve, 10000));
 
  this.toggleProperty('isOpen');

app/components/build-message.js

@@ -5,9 +5,9 @@ import { and, notEmpty } from '@ember/object/computed';
 import { htmlSafe } from '@ember/string';
 import { typeOf } from '@ember/utils';
 import { codeblockName } from 'travis/utils/format-config';
-import Ember from 'ember';
+import { Handlebars } from 'ember';
 
-const { escapeExpression: escape } = Ember.Handlebars.Utils;
+const { Utils: { escapeExpression: escape } } = Handlebars;
 
 export default Component.extend({
  tagName: '',

app/components/queued-jobs.js

@@ -1,5 +1,5 @@
 import Component from '@ember/component';
-import Ember from 'ember';
+import {testing} from 'ember';
 import { reads } from '@ember/object/computed';
 import config from 'travis/config/environment';
 import Visibility from 'visibilityjs';
@@ -13,7 +13,7 @@ export default Component.extend({
 
  init() {
  this._super(...arguments);
- if (!Ember.testing) {
+ if (!testing) {
  return Visibility.every(config.intervals.updateTimes, this.updateTimes.bind(this));
  }
  },

app/components/repository-sidebar.js

@@ -1,7 +1,7 @@
 import { isEmpty } from '@ember/utils';
 import { schedule } from '@ember/runloop';
 import Component from '@ember/component';
-import Ember from 'ember';
+import {testing} from 'ember';
 import Visibility from 'visibilityjs';
 import { task } from 'ember-concurrency';
 import { computed } from '@ember/object';
@@ -42,7 +42,7 @@ export default Component.extend({
  this.set('_data', this.get('repositories.accessible'));
  }
 
- if (!Ember.testing) {
+ if (!testing) {
  Visibility.every(config.intervals.updateTimes, () => {
  const callback = (record) => record.get('currentBuild');
  const withCurrentBuild = this._data.filter(callback).map(callback);

app/components/running-jobs.js

@@ -1,5 +1,5 @@
 import Component from '@ember/component';
-import Ember from 'ember';
+import {testing} from 'ember';
 import { reads } from '@ember/object/computed';
 import config from 'travis/config/environment';
 import Visibility from 'visibilityjs';
@@ -13,7 +13,7 @@ export default Component.extend({
 
  init() {
  this._super(...arguments);
- if (!Ember.testing) {
+ if (!testing) {
  return Visibility.every(config.intervals.updateTimes, this.updateTimes.bind(this));
  }
  },

app/components/top-bar.js

@@ -1,6 +1,6 @@
 import { scheduleOnce } from '@ember/runloop';
 import Component from '@ember/component';
-import Ember from 'ember';
+import {testing} from 'ember';
 import {
  computed,
  setProperties,
@@ -84,7 +84,7 @@ export default class TopBar extends Component {
  }
 
  didInsertElement() {
- if (Ember.testing) {
+ if (testing) {
  super.didInsertElement(...arguments);
  return;
  }

app/controllers/build.js

@@ -1,5 +1,5 @@
 import Controller, { inject as controller } from '@ember/controller';
-import Ember from 'ember';
+import {testing} from 'ember';
 import Polling from 'travis/mixins/polling';
 import Visibility from 'visibilityjs';
 import config from 'travis/config/environment';
@@ -28,7 +28,7 @@ export default Controller.extend(Polling, {
 
  init() {
  this._super(...arguments);
- if (!Ember.testing) {
+ if (!testing) {
  return Visibility.every(config.intervals.updateTimes, this.updateTimes.bind(this));
  }
  },

app/controllers/dashboard/builds.js

@@ -1,5 +1,5 @@
 import Controller from '@ember/controller';
-import Ember from 'ember';
+import {testing} from 'ember';
 import Visibility from 'visibilityjs';
 import { inject as service } from '@ember/service';
 import config from 'travis/config/environment';
@@ -9,7 +9,7 @@ export default Controller.extend({
 
  init() {
  this._super(...arguments);
- if (!Ember.testing) {
+ if (!testing) {
  Visibility.every(config.intervals.updateTimes, this.updateTimes.bind(this));
  }
  },

app/controllers/index.js

@@ -1,5 +1,5 @@
 import Controller from '@ember/controller';
-import Ember from 'ember';
+import {testing} from 'ember';
 import { computed } from '@ember/object';
 import { alias } from '@ember/object/computed';
 import Visibility from 'visibilityjs';
@@ -18,7 +18,7 @@ export default Controller.extend({
 
  init() {
  this._super(...arguments);
- if (!Ember.testing) {
+ if (!testing) {
  return Visibility.every(config.intervals.updateTimes, this.updateTimes.bind(this));
  }
  },

app/controllers/repo.js

@@ -1,7 +1,7 @@
 import { scheduleOnce } from '@ember/runloop';
 import { isEmpty } from '@ember/utils';
 import Controller, { inject as controller } from '@ember/controller';
-import Ember from 'ember';
+import {testing} from 'ember';
 import eventually from 'travis/utils/eventually';
 import Visibility from 'visibilityjs';
 import { inject as service } from '@ember/service';
@@ -63,7 +63,7 @@ export default Controller.extend({
 
  init() {
  this._super(...arguments);
- if (!Ember.testing) {
+ if (!testing) {
  Visibility.every(config.intervals.updateTimes, this.updateTimes.bind(this));
  }
  },

app/helpers/commit-link.js

@@ -1,10 +1,10 @@
-import Ember from 'ember';
+import { Handlebars } from 'ember';
 import { htmlSafe } from '@ember/string';
 import Helper from '@ember/component/helper';
 import { inject as service } from '@ember/service';
 import formatCommit from 'travis/utils/format-commit';
 
-const { escapeExpression: escape } = Ember.Handlebars.Utils;
+const { Utils: { escapeExpression: escape } } = Handlebars;
 
 export default Helper.extend({
  externalLinks: service(),

app/services/animation.js

@@ -1,9 +1,9 @@
 import Service from '@ember/service';
 import { computed } from '@ember/object';
-import Ember from 'ember';
+import {testing} from 'ember';
 import fade from 'ember-animated/transitions/fade';
 
-const isTest = Ember.testing;
+const isTest = testing;
 
 export const DURATION_NAMES = {
  QUICK: 'quick',

app/templates/account-error.hbs

@@ -16,6 +16,5 @@
  If you believe you've received this message in error, please
  <LinkTo @route="help" @query={{hash anchor="form"}}>
  contact support.
- </LinkTo>
- </p>
+ </LinkTo> </p>
 </div>

app/templates/account/settings.hbs

@@ -110,8 +110,7 @@
  @query={{hash tab="insights"}}
  >
  View {{this.account.fullName}}'s Insights
- </LinkTo>
- </p>
+ </LinkTo> </p>
  <VisibilitySettingList
  @options={{this.insightsVisibilityOptions}}
  @initialKey={{this.privateInsightsVisibility}}

app/templates/application.hbs

@@ -1,3 +1,4 @@
+{{head-layout}}
 {{#let this.features as |f|}}
  <HeadLayout />
  <div class="feature-wrapper {{if f.dashboard 'dashboard'}} {{if f.pride 'travis-pride'}} {{if f.comicSans 'travis-comicsans'}}">

app/templates/components/email-unsubscribe.hbs

@@ -34,8 +34,7 @@
  class="repo-link repo-slug"
  >
  {{this.repo.formattedSlug}}
- </LinkTo>
- </h1>
+ </LinkTo> </h1>
  <p class="description" data-test-email-unsubscribe-description>
  {{#if this.isSubscribed}}
  Please confirm that you would like to unsubscribe from build emails for the

app/templates/components/job-tabs.hbs

@@ -10,8 +10,7 @@
  data-test-job-log-tab="true"
  >
  Job log
- </LinkTo>
- </li>
+ </LinkTo> </li>
  <li>
  <LinkTo
  @route="job.config"
@@ -32,8 +31,7 @@
  <EmberTooltip @text={{this.messagesBadgeTooltipText}} />
  </span>
  {{/if}}
- </LinkTo>
- </li>
+ </LinkTo> </li>
  </ul>
 </nav>
 <div class="travistab-body job-tabs">

app/templates/components/link-to-account.hbs

@@ -1,8 +1,7 @@
 {{#if this.routeModel}}
  <LinkTo @route={{this.routeName}} @model={{this.routeModel}} class={{@class}}>
  {{yield}}
- </LinkTo>
-{{else}}
+ </LinkTo>{{else}}
  <LinkTo @route={{this.routeName}} class={{@class}}>
  {{yield}}
  </LinkTo>

app/templates/components/plan_usage.hbs

@@ -113,8 +113,7 @@
  @query={{hash serverType=this.repo.serverType}}
  >
  {{repository.formattedSlug}}
- </LinkTo>
- </td>
+ </LinkTo> </td>
  <td>
  {{format-number repository.buildMinutes}}
  </td>

app/templates/components/repo-show-tools.hbs

@@ -16,20 +16,17 @@
  <li>
  <LinkTo @route="settings" @model={{this.repo}}>
  Settings
- </LinkTo>
- </li>
+ </LinkTo> </li>
  {{/if}}
  <li>
  <LinkTo @route="requests" @model={{this.repo}}>
  Requests
- </LinkTo>
- </li>
+ </LinkTo> </li>
  {{#if this.displayCachesLink}}
  <li>
  <LinkTo @route="caches" @model={{this.repo}}>
  Caches
- </LinkTo>
- </li>
+ </LinkTo> </li>
  {{/if}}
  {{#if (and this.displayTriggerBuildLink this.canOwnerBuild)}}
  <li>

app/templates/components/repository-layout.hbs

@@ -7,15 +7,13 @@
  <h1 data-test-repo-header-title class="inline-block vertical-align">
  <LinkTo @route="owner" @models={{array this.repo.provider this.repo.ownerName}} >
  {{this.repo.owner.login}}
- </LinkTo>
- /
+ </LinkTo> /
  <LinkTo
  @route="repo" @models={{array this.repo.provider this.repo.urlOwnerName this.repo.urlName}}
  @query={{hash serverType=this.repo.serverType}}
  >
  {{this.repo.name}}
- </LinkTo>
- </h1>
+ </LinkTo> </h1>
  </div>
  <div>
  <ExternalLinkTo

app/templates/dashboard.hbs

@@ -23,13 +23,11 @@
  <h2 class="small-title">
  <LinkTo @route="dashboard.repositories" data-test-active-repos-tab="true">
  Active repositories
- </LinkTo>
- </h2>
+ </LinkTo> </h2>
  <h2 class="small-title">
  <LinkTo @route="dashboard.builds" data-test-my-builds-tab="true">
  My builds
- </LinkTo>
- </h2>
+ </LinkTo> </h2>
  </header>
  {{outlet}}
 </TravisLayout>

app/templates/owner/repositories.hbs

@@ -3,13 +3,11 @@
  <li>
  <LinkTo @query={{hash tab="repositories" timeInterval=this.defaultTimeInterval}} >
  Repositories
- </LinkTo>
- </li>
+ </LinkTo> </li>
  <li>
  <LinkTo @query={{hash tab="insights" timeInterval=this.timeInterval page=1}}>
  Insights
- </LinkTo>
- </li>
+ </LinkTo> </li>
  </ul>
 </nav>
 <div class="owner-repo">

app/templates/settings.hbs

@@ -317,17 +317,15 @@
  class="migrated-repo-settings-modal__button button--blue"
  >
  View Build History
- </LinkTo>
- <ExternalLinkTo
+ </LinkTo> <ExternalLinkTo
  @href={{this.migratedRepositorySettingsLink}}
  class="migrated-repo-settings-modal__button button--dark-grey"
  >
  Edit settings on .com
  </ExternalLinkTo>
  <LinkTo @route="repo.index" @models={{array repo.provider repo.ownerName repo.vcsName}} class="modal-close pointer">
  <SvgImage @name="icon-failed" @class="icon" />
- </LinkTo>
- </div>
+ </LinkTo> </div>
  </div>
 </Modal>
 <Dialogs::UserManagementModal

config/environment.js

@@ -396,14 +396,6 @@ module.exports = function (environment) {
 
  ENV.logLimit = 100;
 
- ENV.percy = {
- breakpointsConfig: {
- mobile: 375,
- desktop: 1280
- },
- defaultBreakpoints: ['mobile', 'desktop']
- };
-
  ENV.featureFlags['debug-logging'] = false;
  ENV.featureFlags['dashboard'] = false;
  ENV.featureFlags['pro-version'] = false;