Use Setter in OverwriteOnNil if a :setter is defined #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,13 @@ module Representable | |||
| end | |||
|
|
|||
| OverwriteOnNil = ->(input, options) do | |||
| input.nil? ? (SetValue.(input, options); Pipeline::Stop) : input | |||
| if input.nil? | |||
| function = options[:binding][:setter] ? Setter : SetValue | |||
There was a problem hiding this comment.
This is correct, but we can't inspect this at runtime for performance reasons, we have to maintain two Override functions and set them at compile time.
There was a problem hiding this comment.
I see, so rewrite the PR to make the pipeline factory pick which OverwriteOnNil function to use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be misunderstanding the intention of
OverwriteOnNil, but it seems like you'd want to useSetterif a:setteris defined for the property.If I am misunderstanding, please clarify why the supplied test case is invalid. Thanks!