Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_completion.py #2193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AranavMahalpure
Copy link

@AranavMahalpure AranavMahalpure commented Oct 22, 2024

  • I have added tests that cover my changes.

    • Added two tests: test_capture_system_message and test_edge_case_empty_message to verify the handling of system messages.
  • PR name follows conventional commits format: feat(instrumentation): add tests for capturing system messages.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. testing labels Oct 22, 2024
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AranavMahalpure, this looks like an LLM generated code that doesn't even work - there's no method called capture_system_message in the Anthropic class. Please make sure to run the tests before submitting a PR. I'm not sure what are you testing here, why is it needed, and it doesn't even work.

system_message = "This is a test system message."

# Simulate capturing a system message
client.capture_system_message(system_message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you ran this? there's no method like this on Anthropic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files. testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants