Avoid 1s delay on consequent lock in windows #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use winapi LockFile instead of msvcrt.locking in order to avoid 1s delay when file is locked
awaizman1
changed the title
gaborbernat
reviewed
Sep 27, 2021
gaborbernat
requested changes
Sep 27, 2021
gaborbernat
force-pushed
the
main
branch
2 times, most recently
from
434d99e
to
a4f87da
Compare
|
Closing due to lack of response, we'll reopen if this gets traction again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use winapi LockFile instead of msvcrt.locking in order to avoid 1s delay when file is locked
in windows when the file is locked (using msvcrt.locking) another attempt to lock it will take 1s (just to see its already locked). using winapi FileLock instead doesn't have this buggy implemetation.
for more details see this issue