Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7265 - Accessibility | ADR_21184-5 Anchor tags with no href do not receive keyboard focus #1059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickcuagan
Copy link
Collaborator

Ticket: https://torchbox.monday.com/boards/1472452416/pulses/1663117265

This PR makes some accessibility fixes to some elements in the build:

  • In the navigation, 'Back' is set to as a link which is not focusable. We update this to be a button.
  • When opening a video embed, the close button is not focusable as well. We update this to be a button.

In the ticket/document, there's a link in https://www.rca.ac.uk/study/programme-finder/art-design-graduate-diploma/ which is not focusable -- specifically the one with the text "Next on-campus open day: 16 October 2024". This is caused by a broken link so that just needs to be updated editorially.

@patrickcuagan patrickcuagan force-pushed the updates/7265-anchor-tags-accessibility branch from aad445b to 6bcb661 Compare October 21, 2024 01:14
@patrickcuagan patrickcuagan force-pushed the updates/7265-anchor-tags-accessibility branch from 6bcb661 to aa7f10e Compare October 21, 2024 01:15
@siimonevans siimonevans self-requested a review October 21, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants