Update google wellknown protos #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-abrahamsson
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Thanks! Sorry for the delay.
It generally looks fine. I have only one comment about stating the version. There is a command to import protos from a local protobuf repo, and prepend a version comment, helpers/import-protobuf-protos, but I noticed it had gotten somewhat outdated[*] so I have an updated import-protobuf-protos on a branch.
[*] the protobuf repo layout has changed so it couldn't find the version number automatically any more.
The new proto types is imported from protobuf 4.25.1
gilbertwong96
force-pushed
the
feature/update-google-wellknow-protos
branch
from
85562aa
to
0ad3c54
Compare
|
It's cool. I didn't notice this script. |
|
Thanks! I've merged it locally for inclusion in the next release, which probably won't be far away (keeping this pr open until then) |
|
This is now included in gpb 4.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that the Google well-known proto types in this repository are currently fixed at version 3.12.3, which seems a bit outdated.
This pull request addresses this by updating the Protobufs file.