metrics: rename *_poll_count_* to *_poll_time_*
#6924
Merged
+119
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
Darksonn
reviewed
Oct 21, 2024
A consistent bit of feedback I've heard is that the `poll_count_histogram` name is a little confusing since the value customers actually get out of it is `poll_times`. This renames all public APIs from `poll_count` to `poll_time`. The existing APIs were deprecated with one exception: the newly added `poll_count_histogram_configuration` which hasn't been released yet was simply renamed.
rcoh
force-pushed
the
poll-time-histogram-rename
branch
from
5a72aca
to
9b25f46
Compare
rcoh
force-pushed
the
poll-time-histogram-rename
branch
from
b437e47
to
07ae5b1
Compare
mox692
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: If this PR does not make the 1.41 release, one more deprecation needs to be added prior to merge
Motivation
A consistent bit of feedback I've heard is that the
poll_count_histogramname is a little confusing since the value customers actually get out of it ispoll_times.Solution
This renames all public APIs from
poll_counttopoll_time. The existing APIs were deprecated with one exception: the newly addedpoll_count_histogram_configurationwhich hasn't been released yet was simply renamed.