New command to list jobs failing by view #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toabctl
reviewed
Apr 21, 2023
jentool/__init__.py
Outdated
| @@ -103,6 +103,11 @@ def _parser(): | |||
| parser_jobs_failing.add_argument('pattern', metavar='pattern', help='the Jenkins job name(s) (regex)') | |||
| parser_jobs_failing.add_argument('--max-score', '-m', default=0, type=int, help='the maximum health score to look for') | |||
| parser_jobs_failing.set_defaults(func=jobs_failing) | |||
| # jobs failing by view | |||
| parser_jobs_failing_by_view = subparsers.add_parser( | |||
There was a problem hiding this comment.
could that be included in jobs-failing eg. with jentool jobs-failing --use-view my-view-name ?
There was a problem hiding this comment.
So it's not that simple because get_jobs and get_jobs_info_regex do not take the same parameters nor return the same values. For example, get_jobs_info_regex doesn't let you filter by views and it returns the score in the info dict while get_jobs doesn't.
This is way faster than relying on regexp and is super useful to quickly identify failing jobs
gjolly
force-pushed
the
jobs-failing-by-view
branch
from
c4511aa
to
35afd7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is way faster than relying on regexp and is super useful to quickly identify failing jobs